On Mon, Feb 01, 2010 at 10:35:18AM -0700, Alex Chiang wrote: > Hi Chris, > > Thanks for catching this. Seems better to just memset the stack > variable before we kmemdup it in platform_deivce_register_data(). > > How about this instead? [ memset instead of explicitly setting flags to zero ] I didn't do the memset because lower down we init every other field, but zeros are zeros really. Looking at platform_device_register_data, you could even make ds static...now that is sure to break in small and subtle ways later on ;) -chris -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html