Re: [patch] hp-wmi: fix double free

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 1/10/10, Dan Carpenter <error27@xxxxxxxxx> wrote:
> kfree(obj) was called earlier.
>
> This was found by smatch and has only been compile tested.  :/

I don't see hp-wmi in MAINTAINERS, but in general platform drivers go
via the ACPI tree.

It looks like several others have discovered this issue the hard way
:-).  <http://www.pubbs.net/kernel/201001/14288/>.

Fortunately it has been fixed in the acpi tree and now submitted to
Linus.  <http://linux.derkeiler.com/Mailing-Lists/Kernel/2010-01/msg02511.html>.

Regards
Alan

> --- orig/drivers/platform/x86/hp-wmi.c	2010-01-09 21:43:13.000000000 +0300
> +++ devel/drivers/platform/x86/hp-wmi.c	2010-01-09 21:43:28.000000000 +0300
> @@ -388,8 +388,6 @@ static void hp_wmi_notify(u32 value, voi
>  	} else
>  		printk(KERN_INFO "HP WMI: Unknown key pressed - %x\n",
>  			eventcode);
> -
> -	kfree(obj);
>  }
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux