The function that is executing in workqueue context does not need
to sleep so let's switch to a timer which is more lightweight.
Signed-off-by: Dmitry Torokhov <dtor@xxxxxxx>
---
drivers/platform/x86/sony-laptop.c | 22 +++++++++++-----------
1 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/platform/x86/sony-laptop.c b/drivers/platform/x86/sony-laptop.c
index acb3933..d161735 100644
--- a/drivers/platform/x86/sony-laptop.c
+++ b/drivers/platform/x86/sony-laptop.c
@@ -144,6 +144,7 @@ struct sony_laptop_input_s {
struct input_dev *key_dev;
struct kfifo *fifo;
spinlock_t fifo_lock;
+ struct timer_list release_key_timer;
};
static struct sony_laptop_input_s sony_laptop_input = {
@@ -295,10 +296,8 @@ static int sony_laptop_input_keycode_map[] = {
};
/* release buttons after a short delay if pressed */
-static void do_sony_laptop_release_key(struct work_struct *work)
+static void do_sony_laptop_release_key(unsigned long unused)
{
- struct delayed_work *dwork =
- container_of(work, struct delayed_work, work);
struct sony_laptop_keypress kp;
if (kfifo_get(sony_laptop_input.fifo,
@@ -308,18 +307,16 @@ static void do_sony_laptop_release_key(struct work_struct *work)
}
/*
- * If there is something in the fifo scnhedule nect release.
+ * If there is something in the fifo schedule next release.
* We don't care about locking, at worst we may schedule an
* extra "empty" wakeup. This may be improved with the new
* kfifo API.
*/
if (__kfifo_len(sony_laptop_input.fifo) != 0)
- schedule_delayed_work(dwork, msecs_to_jiffies(10));
+ mod_timer(&sony_laptop_input.release_key_timer,
+ jiffies + msecs_to_jiffies(10));
}
-static DECLARE_DELAYED_WORK(sony_laptop_release_key_work,
- do_sony_laptop_release_key);
-
/* forward event to the input subsystem */
static void sony_laptop_report_input_event(u8 event)
{
@@ -376,8 +373,8 @@ static void sony_laptop_report_input_event(u8 event)
/* schedule key release */
kfifo_put(sony_laptop_input.fifo,
(unsigned char *)&kp, sizeof(kp));
- schedule_delayed_work(&sony_laptop_release_key_work,
- msecs_to_jiffies(10));
+ mod_timer(&sony_laptop_input.release_key_timer,
+ jiffies + msecs_to_jiffies(10));
} else
dprintk("unknown input event %.2x\n", event);
}
@@ -404,6 +401,9 @@ static int sony_laptop_setup_input(struct acpi_device *acpi_device)
goto err_dec_users;
}
+ setup_timer(&sony_laptop_input.release_key_timer,
+ do_sony_laptop_release_key, 0);
+
/* input keys */
key_dev = input_allocate_device();
if (!key_dev) {
@@ -487,7 +487,7 @@ static void sony_laptop_remove_input(void)
if (!atomic_dec_and_test(&sony_laptop_input.users))
return;
- cancel_delayed_work_sync(&sony_laptop_release_key_work);
+ del_timer_sync(&sony_laptop_input.release_key_timer);
/* Generate key-up events for remaining keys */
while (kfifo_get(sony_laptop_input.fifo,
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
