Re: [PATCH 2/2] update mutex usage in aggregator driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 14, 2009 at 09:42:29AM +0800, Chen Gong wrote:
> I have 2 issues.
>  1. I consider thread creation and RR thread execution don't share the
> global data, so the serialization execution is not necessary. It is
> enough to use another different mutex to lock thread exectuion itself
> when these threads running concurrently.
>  2. part of sysfs interfaces doesn't need to own mutex with thread createion.
> Though some data maybe are not identical, it is not a big deal.
ACK the first patch.
NACK this one. I don't see any reason we need two locks here. This isn't hot
code path, fine-grained lock just makes thing complex.

Thanks,
Shaohua 
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux