Re: Dock OOPSing with recent acpi-test

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Len Brown <lenb@xxxxxxxxxx>:
> On Wed, 18 Nov 2009, Dmitry Torokhov wrote:
> 
> > The day before yesterday pull from acpi-test + Linux's tip produces the
> > following oops in the dock driver (see screenshot).
> 
> Dmitry, do you still see this?
> If you build with drivers/acpi/dock.c from 2.6.32 does it go away?

I figured out what the issue was:

http://www.spinics.net/lists/linux-acpi/msg25223.html

+static int
+add_dock_dependent_device(acpi_handle handle, struct dock_station *ds)

...

+	if (tmp == ds->handle)
+		add_dock_dependent_device(ds, handle);

...

+	ret = add_dock_dependent_device(dock_station, handle);
+	if (ret)
 		goto err_rmgroup;

I wrote the function signature one way, but called it a different
way. How odd, I never got a compiler type warning (that I can
recall).

Queueing up a patch for Len now.

Sorry about that.
/ac

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux