On Wed, 2009-12-02 at 15:33 +0530, Arun R Bharadwaj wrote: > +int boot_option_idle_override = 0; > + Doesn't need to be set to zero AFAIK, since we do a mass initialization to zero during boot up. Did you notice some type of failure when you didn't initialize that to zero? (checkpatch output below..) -- ERROR: do not initialise externals to 0 or NULL #97: FILE: arch/powerpc/kernel/idle.c:43: +int boot_option_idle_override = 0; total: 1 errors, 0 warnings, 0 checks, 31 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html