On Thu, Nov 26, 2009 at 12:07 AM, Matthew Garrett <mjg59@xxxxxxxxxxxxx> wrote: > On Wed, Nov 25, 2009 at 01:24:50PM -0500, Len Brown wrote: > >> Have these been verified as necessary to make sound work on >> the specified models, or are these speculative patches? > > To clarify - these patches do *nothing* to make sound work. They change > the behaviour of the mute key from changing the hardware state of the > mixer and not sending a key event to instead sending a key event and > requring that software perform the change. The behavioural change is > primarily cosmetic rather than functional. I'm not convinced that this > is a sensible thing to do at this point in the release cycle, given that > we have no testing of what other behavioural changes the firmware may > make. It's a functional change in the sense that the mixer is not usefully supported right now (it's a file in /proc/acpi/ibm which is nonstandard and which no one should reasonably be expected to know about), it's useless (the standard HDA mixer works just fine), and without this change the mute button breaks sound for everyone except power users (who else is supposed to know to twiddle /proc/acpi/ibm/volume or press "sound up" to get sound back when the ALSA controls are already unmuted and set to maximum volume). I'll grant that, with this change, Linux works differently from Windows, but I'm not sure that's a good argument for leaving this change out. IMO in an ideal world, Lenovo would stop looking at OSI(Linux) and would also eliminate their weird mixer interface completely. At least with this change we can continue ignoring the weird mixer interface until we have proper ALSA integration. --Andy -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
