andrej.gelenberg@xxxxxxx wrote:
Hi,
Corentin Chary writes:
Matthew, you added hotplug in commit
5740294ca3a9b113fe146f2826effb69ca50008d,
it was needed for 701/900/901. Do you know if it's still needed for
1005ha ?
Is it not better to use rfkill-switch provided from wlan-driver when?
At least Atheros drivers support rfkill propertly. You can make it LED
for that eeepcs and set the default trigger to rfkill. I have tried to
make it so, but on 1005ha it is a proper rfkill.
I have tried to make the devicesearch for hotplug propertly, but it cause
the system freeze. (http://bugzilla.kernel.org/show_bug.cgi?id=14570#c1)
At least on the original systems, the eeepc-laptop driver has no way to
control the wireless LED directly. The wireless LED is set by the WLDS
acpi method (when the wireless is enabled/disabled).
The pci hotplug in the eeepc-laptop driver doesn't actually save any
power. The WLDS acpi method is what actually "unplugs" the PCI slot.
What eeepc-laptop does is notify the kernel after the fact, so that the
wireless driver doesn't try to talk to hardware that isn't there.
Without this notification, the wireless driver isn't able to recover
when the wireless is toggled off and back on again.
Unfortunately, the BIOS doesn't tell us in advance which device it is
going to unplug. Hence the hardcoded bus/slot.
We may be able to filter the notifications. The _ADR field on the P0P*
devices tells us which PCI bridge device it corresponds to. So we can
hopefully avoid toggling the wrong device and disabling the LAN on 1005ha.
But I don't know how to find the _right_ device in a generic way (or
detect that hotplug is not needed and so we should not toggle any device).
Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
