Dell's mobile BIOS implements a platform-level check for the bus device
that triggered the PME# GPE. The GPE triggers an SMI, which in turn
causes notifications to be sent to only the devices that require it.
Unfortunately, this SMI is incorrect and fails to generate any notifications.
The wakeup device's PME line thus remains asserted, triggering another GPE
and executing the SMI again. As no notification will ever be sent, the
device is never powered up and the PME bit never cleared. This is less than
optimal.
This issue was supposed to be fixed in systems with an OEM table ID of M09
or higher - unfortunately, it seems that that isn't the case. So, for now,
disable the GPE and allow it to be replaced with an OS-level handler (on
Intel) or ignored (on other chipsets)
Signed-off-by: Matthew Garrett <mjg@xxxxxxxxxx>
---
drivers/pci/pci-acpi.c | 24 ++++++++++++++++++++++++
1 files changed, 24 insertions(+), 0 deletions(-)
diff --git a/drivers/pci/pci-acpi.c b/drivers/pci/pci-acpi.c
index 7fff59c..1606d06 100644
--- a/drivers/pci/pci-acpi.c
+++ b/drivers/pci/pci-acpi.c
@@ -14,6 +14,7 @@
#include <linux/pci-aspm.h>
#include <acpi/acpi.h>
#include <acpi/acpi_bus.h>
+#include <linux/dmi.h>
#include <linux/pci-acpi.h>
#include "pci.h"
@@ -970,12 +971,35 @@ static void __init acpi_pci_install_gpe(u32 gpe_number,
}
}
+static int __init acpi_gpe_remove_0xd_method(const struct dmi_system_id *d)
+{
+ acpi_remove_gpe_method(NULL, 0xd);
+ return 0;
+}
+
+static struct dmi_system_id gpe_dmi_table[] __initdata = {
+ /*
+ * Dells have a broken handler for GPE 0xd. Remove it rather than
+ * trusting it
+ */
+ {
+ .callback = acpi_gpe_remove_0xd_method,
+ .ident = "Dell",
+ .matches = {
+ DMI_MATCH(DMI_BOARD_VENDOR, "Dell Inc."),
+ },
+ },
+ {}
+};
+
static int __init acpi_pci_gpe_fixups(void)
{
struct pci_dev *lpc;
struct gpe_fixup *fixups;
int i;
+ dmi_check_system(gpe_dmi_table);
+
lpc = pci_get_class(PCI_CLASS_BRIDGE_ISA << 8, NULL);
if (!lpc)
--
1.6.5.2
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
