On Mon, Nov 9, 2009 at 11:54 AM, Matthew Garrett <mjg59@xxxxxxxxxxxxx> wrote: > On Mon, Nov 09, 2009 at 11:47:30AM -0500, Andrew Lutomirski wrote: >> The ThinkPad X200s, like the X61, requires OSI=Linux for the mute >> button to work. Without this patch (or the equivalent command-line >> parameter), the mute button does not generate a keystroke and, >> instead, messes up the sound hardware. > > No. How does this work on Windows? Note that we *have* a special driver > for Thinkpads, and it's entirely acceptable to require it in order to > have sensible behaviour. We do not want to encourage vendors to > special-case Linux. The Thinkpad mixer is really weird AFAICT. I have no idea how the mute button works in Windows with the driver, but I'm not sure that it looks like a key press -- I think it does something to the mixer and the driver detects it. cc: Henrique: can we fix this in thinkpad-acpi? I actually think the "Linux" behavior makes more sense -- the volume up and down buttons already work on all operating systems, and with this patch the mute button works the same way. There's precedent for this hack, and regardless of what we want to convince Lenovo to do, making existing hardware work is nice: http://bugzilla.kernel.org/show_bug.cgi?id=9907 --Andy -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
