Cyrill Gorcunov wrote:
[David Rientjes - Tue, Oct 27, 2009 at 12:45:00PM -0700]
...
| On Tue, 27 Oct 2009, Mike Travis wrote:
| +
| +void __init acpi_numa_print_srat_mapping(void)
| +{
| + DECLARE_BITMAP(apicid_map, MAX_LOCAL_APIC);
| + char apicid_list[MAX_LOCAL_APIC];
Hi David, I suppose 32K on stack is too much :)
(perhaps gcc will move it out of stack?)
...
-- Cyrill
Yeah, I missed that too on my first review. (4k seems piddling
compared to 32k on the stack! ;-)
I moved them both to static and will be testing it shortly:
static DECLARE_BITMAP(apicid_map, MAX_LOCAL_APIC) __initdata;
static char apicid_list[MAX_LOCAL_APIC] __initdata;
Thanks,
Mike
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
