On Tuesday 27 October 2009 09:27:35 am Mike Travis wrote:
> Bjorn Helgaas wrote:
> ...
> >
> > I know we print way too much stuff for every processor, but again, I'd
> > rather see all CPUs or none. I think there's a little more value in
> > this one than the cooling device one (probably because I do a lot of
> > platform bringup), but it could certainly be made KERN_DEBUG and/or
> > combined with another processor discovery line.
>
> Is this more acceptable?
>
> Thanks,
> Mike
> ---
>
> SGI x86_64 UV: Limit the number of ACPI messages
>
> Limit number of ACPI messages of the form:
>
> [ 0.000000] ACPI: LSAPIC (acpi_id[0x00] lsapic_id[0x00] lsapic_eid[0x00] enabled)
>
> [ 99.638655] processor ACPI0007:00: registered as cooling_device0
>
> Cc: Zhang Rui <rui.zhang@xxxxxxxxx>
> Cc: Len Brown <lenb@xxxxxxxxxx>
> Cc: Thomas Renninger <trenn@xxxxxxx>
> Cc: Bjorn Helgaas <bjorn.helgaas@xxxxxx>
> Cc: Alexey Dobriyan <adobriyan@xxxxxxxxx>
> Cc: Myron Stowe <myron.stowe@xxxxxx>
> Cc: Feng Tang <feng.tang@xxxxxxxxx>
> Cc: Suresh Siddha <suresh.b.siddha@xxxxxxxxx>
> Cc: Yinghai Lu <yhlu.kernel@xxxxxxxxx>
> Cc: linux-acpi@xxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Signed-off-by: Mike Travis <travis@xxxxxxx>
> ---
> drivers/acpi/fan.c | 2 +-
> drivers/acpi/processor_core.c | 3 +--
> drivers/acpi/tables.c | 13 ++++++++-----
> 3 files changed, 10 insertions(+), 8 deletions(-)
>
> --- linux.orig/drivers/acpi/fan.c
> +++ linux/drivers/acpi/fan.c
> @@ -267,7 +267,7 @@
> goto end;
> }
>
> - dev_info(&device->dev, "registered as cooling_device%d\n", cdev->id);
> + dev_dbg(&device->dev, "registered as cooling_device%d\n", cdev->id);
>
> device->driver_data = cdev;
> result = sysfs_create_link(&device->dev.kobj,
> --- linux.orig/drivers/acpi/processor_core.c
> +++ linux/drivers/acpi/processor_core.c
> @@ -845,8 +845,7 @@
> goto err_power_exit;
> }
>
> - dev_info(&device->dev, "registered as cooling_device%d\n",
> - pr->cdev->id);
> + dev_dbg(&device->dev, "registered as cooling_device%d\n", pr->cdev->id);
I still think you should just remove these messages completely.
If you do keep them, note that dev_dbg() is not the same as
dev_prinkt(KERN_DEBUG) -- dev_dbg() compiles to nothing at all
unless "DEBUG" is defined.
> result = sysfs_create_link(&device->dev.kobj,
> &pr->cdev->device.kobj,
> --- linux.orig/drivers/acpi/tables.c
> +++ linux/drivers/acpi/tables.c
> @@ -170,11 +170,14 @@
> case ACPI_MADT_TYPE_LOCAL_SAPIC:
> {
> struct acpi_madt_local_sapic *p =
> - (struct acpi_madt_local_sapic *)header;
> - printk(KERN_INFO PREFIX
> - "LSAPIC (acpi_id[0x%02x] lsapic_id[0x%02x] lsapic_eid[0x%02x] %s)\n",
> - p->processor_id, p->id, p->eid,
> - (p->lapic_flags & ACPI_MADT_ENABLED) ? "enabled" : "disabled");
> + (struct acpi_madt_local_sapic *)header;
> +
> + printk(KERN_DEBUG PREFIX
> + "LSAPIC (acpi_id[0x%02x] "
> + "lsapic_id[0x%02x] lsapic_eid[0x%02x] %s)\n",
> + p->processor_id, p->id, p->eid,
> + (p->lapic_flags & ACPI_MADT_ENABLED) ?
> + "enabled" : "disabled");
I don't object to this.
I do think it'd be much better to combine this with the other
per-processor startup messages, of which we have an absolute over-
abundance:
CPU0: Intel(R) Xeon(TM) CPU 2.80GHz stepping 09
Booting processor 1 APIC 0x6 ip 0x6000
Initializing CPU#1
Calibrating delay using timer specific routine.. 5597.14 BogoMIPS (lpj=2798571)
CPU: Trace cache: 12K uops, L1 D cache: 8K
CPU: L2 cache: 512K
CPU: Physical Processor ID: 3
CPU: Processor Core ID: 0
But that's a bigger project.
Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
