* Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>: > > If sysfs_create_group() fails you will go to err_unregister: > which will try to remove the non-existing group. While the > current sysfs code is relsilient against such errors it may not > be so in the future. It is better to have a separate label and > bypass sysfs_remove_group() if sysfs_create_group() returned > error. Yeah, you're right. I was trying to be lazy (everyone else is doing it!), but I guess you won't let me. ;) I'll respin. Thanks for the review. /ac -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html