On Wednesday 14 October 2009 12:47:33 am Yinghai Lu wrote: > On Tue, Oct 13, 2009 at 12:21 PM, Bjorn Helgaas <bjorn.helgaas@xxxxxx> wrote: > > These enhance %pR so we can print resource types and flags more easily. > > This doesn't really add anything (other than a couple new messages > > about host bridge apertures), but hopefully it will make things more > > consistent and a bit easier to debug. Sample change (with "pci=use_crs"): > > > > -pci 0000:00:03.0: reg 10 32bit mmio: [0xf6000000-0xf6ffffff] > > -pci 0000:00:03.0: reg 14 io port: [0x2400-0x24ff] > > -pci 0000:00:03.0: reg 18 32bit mmio: [0xf5ff0000-0xf5ff0fff] > > -pci 0000:00:03.0: reg 30 32bit mmio pref: [0x000000-0x01ffff] > > +pci_root PNP0A03:00: host bridge window [io 0x0000-0x0cff] > > +pci_root PNP0A03:00: host bridge window [io 0x0000-0x2cfe] > > +pci_root PNP0A03:00: host bridge window [io 0x03b0-0x03bb] > > +pci_root PNP0A03:00: host bridge window [io 0x03c0-0x03df] > > +pci_root PNP0A03:00: host bridge window [mem 0xf5d00000-0xf6ffffff] > > +pci_root PNP0A03:00: host bridge window [mem 0x000a0000-0x000bffff] > > +pci 0000:00:03.0: reg 10: [mem 0xf6000000-0xf6ffffff] > > +pci 0000:00:03.0: reg 14: [io 0x2400-0x24ff] > > +pci 0000:00:03.0: reg 18: [mem 0xf5ff0000-0xf5ff0fff] > > +pci 0000:00:03.0: reg 30: [mem 0x00000000-0x0001ffff pref] > > can you keep "io port" and "mmio" ? > so we can use > grep "io port" dmesg.txt or grep "mmio" dmesg.txt I don't think that's necessary. If you want to see only resource stuff, these greps will work perfectly: # dmesg | grep "\[io " # dmesg | grep "\[mem " (This is much better than what's in the current tree, where resources are labelled with a hodge-podge of mem, mmio, MEM, io, I/O, io port, IO, or even nothing at all, so you really can't do the grep at all.) > also put "io" and "mmio" "pref' in the [ ], looks strange. > [0xf5ff0000-0xf5ff0fff] is correct range expression. I could be convinced otherwise, but right now, I don't see a correctness issue here -- it's just a matter of what the most convenient format for human readers is. And I personally like the fact that everything inside the brackets is an attribute of the struct resource. If these are the alternatives: bridge window [io 0x0000-0x0cff] bridge window io [0x0000-0x0cff] one nice thing about the first is that the brackets give a clue that you should grep for "bridge window", not "bridge window io", to find the source of the message. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
