Hi Len, * Shaohua Li <shaohua.li@xxxxxxxxx>: > > This patch isn't good. platform_device_add_data will malloc a new > 'struct dock_station' and copy old to it, and later the two copy aren't > consistent. So NACK this one. If you can drop this patch without requiring a respin from me, go ahead. If you can't, go ahead and drop what you need, and I'll respin. I'm going to chew on this a bit and see if I can still salvage it. > ACK other 5 patches. Thanks, Shaohua. /ac -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html