> The wrong test was used acpi_status status is unsigned. > > Signed-off-by: Roel Kluin <roel.kluin@xxxxxxxxx> > --- > diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c > index f35aee5..e3c21ee 100644 > --- a/drivers/platform/x86/fujitsu-laptop.c > +++ b/drivers/platform/x86/fujitsu-laptop.c > @@ -376,7 +376,7 @@ static int get_lcd_level(void) > > status = > acpi_evaluate_integer(fujitsu->acpi_handle, "GBLL", NULL, &state); > - if (status < 0) > + if (ACPI_FAILURE(status)) > return status; > > fujitsu->brightness_level = state & 0x0fffffff; > @@ -398,7 +398,7 @@ static int get_max_brightness(void) > > status = > acpi_evaluate_integer(fujitsu->acpi_handle, "RBLL", NULL, &state); > - if (status < 0) > + if (ACPI_FAILURE(status)) > return status; > > fujitsu->max_brightness = state; Thanks Roel. Looks perfectly reasonable to me. Acked-by: Jonathan Woithe <jwoithe@xxxxxxxxxxxxxxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
