On 10/09/2009 04:19 PM, Matthew Garrett wrote: > On Fri, Oct 09, 2009 at 03:55:10PM -0400, Jeff Mahoney wrote: > >> This version provides the infrastructure to override any ACPI table, but >> only provides support for overriding DSDT. If other tables are desired, >> extending the support is trivial. > > I'm really unenthusiastic about this. The majority of use cases appear > to be people working around Linux bugs and never reporting the bugs to > us, leaving everybody worse off. I agree. In an ideal world this would be unnecessary. It's true that ACPI bugs have become must less common than they used to be but I think users would prefer their machines be usable while the ACPI developers are diagnosing why they need a workaround in the first place. In some cases it's just that the MS AML compiler is just so much more lax than the Intel one. I had a notebook where I had to extract, fix, and rebuild my DSDT and then it worked fine. Without the ability to override it, I would've been stuck. BTW, a similar version of this patch was committed to mainline in Feb 2008 though it was reverted shortly after that. Judging from the commit message, it's because it reintroduced the early userspace bugs. I believe this patch addresses that by not allowing the usermode helper to run until rootfs_initcall has been completed. -Jeff -- Jeff Mahoney SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
