On Tue 2009-09-22 13:42:23, Jonathan Cameron wrote: > Zhang Rui wrote: > > Hi, Jonathan, > > > > this is the refresh ALS sysfs class driver. > > I just introduced one sysfs attribute "illuminance", because > > I didn't catch the exact meaning of the others like "???infrared". > > So it would be great if you can generate an incremental patch > > to introduce the other optional attributes needed, and update > > the documentation as well. :) > Will do, though may just leave it out of first pass of drivers > (as it may be controversial and it would be nice to get something > in place before the arguments begin!) > > All looks nice and clean. The only real question is whether > we want to standardize naming of devices under sysfs (like hwmon does) > or allow the individual drivers to do the naming? Allow the drivers to do the naming. Having useless name like "als0", with als0/name telling me what the driver is is bad. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
