Re: [PATCH] topstar_acpi: add new driver for hotkeys support on Topstar N01

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 9/5/09, Herton Ronaldo Krzesinski <herton@xxxxxxxxxxxxxxx> wrote:
> This adds Topstar Laptop Extras ACPI driver. It enables hotkeys
> functionality with Topstar N01 netbook. Besides hotkeys there are
> other functions exposed by its ACPI firmware, but for now only
> hotkeys reporting on Topstar N01 is supported. Topstar is a chinese
> manufacturer, its website can be currently reached at
> http://www.topstardigital.cn/
>
> Signed-off-by: Herton Ronaldo Krzesinski <herton@xxxxxxxxxxxxxxx>

> +static void __exit acpi_topstar_exit(void)
> +{
> +	acpi_bus_unregister_driver(&acpi_topstar_driver);
> +
> +	printk(KERN_INFO "Topstar Laptop ACPI extras driver unloaded\n");

Oh... and this type of message always strikes me as gratuitous.  rmmod
doesn't happen during normal operation.  So if the user removed the
module... they know they did it.  They can check lsmod if they forget
and are not sure.

If (as a developer) you want to be sure the acpi driver was really
unregistered, you can (and probably should) look in sysfs.

Thanks
Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux