Re: [patch 4/9] toshiba_acpi: return on a fail path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



applied

thanks,
Len Brown, Intel Open Source Technology Center

On Thu, 6 Aug 2009, akpm@xxxxxxxxxxxxxxxxxxxx wrote:

> From: Jiri Slaby <jirislaby@xxxxxxxxx>
> 
> Return from bt_rfkill_poll() when hci_get_radio_state() fails.
> 
> value is invalid in that case and should not be assigned to the rfkill
> state.
> 
> This also fixes a double unlock bug.
> 
> Signed-off-by: Jiri Slaby <jirislaby@xxxxxxxxx>
> Cc: John W. Linville <linville@xxxxxxxxxxxxx>
> Cc: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>
> Cc: Len Brown <len.brown@xxxxxxxxx>
> Cc: Henrique de Moraes Holschuh <hmh@xxxxxxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> ---
> 
>  drivers/platform/x86/toshiba_acpi.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff -puN drivers/platform/x86/toshiba_acpi.c~toshiba_acpi-return-on-a-fail-path drivers/platform/x86/toshiba_acpi.c
> --- a/drivers/platform/x86/toshiba_acpi.c~toshiba_acpi-return-on-a-fail-path
> +++ a/drivers/platform/x86/toshiba_acpi.c
> @@ -335,6 +335,7 @@ static void bt_rfkill_poll(struct rfkill
>  	if (hci_result != HCI_SUCCESS) {
>  		/* Can't do anything useful */
>  		mutex_unlock(&dev->mutex);
> +		return;
>  	}
>  
>  	new_rfk_state = value;
> _
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux