On Mon, 17 Aug 2009 14:43:34 +0200
Frans Pop <elendil@xxxxxxxxx> wrote:
> --- a/drivers/acpi/processor_throttling.c
> +++ b/drivers/acpi/processor_throttling.c
> @@ -62,7 +62,8 @@ struct throttling_tstate {
> #define THROTTLING_POSTCHANGE (2)
>
> static int acpi_processor_get_throttling(struct acpi_processor *pr);
> -int acpi_processor_set_throttling(struct acpi_processor *pr, int state);
> +int acpi_processor_set_throttling(struct acpi_processor *pr,
> + int state, bool force);
>
WARNING: externs should be avoided in .c files
#74: FILE: drivers/acpi/processor_throttling.c:65:
+int acpi_processor_set_throttling(struct acpi_processor *pr,
total: 0 errors, 1 warnings, 137 lines checked
checkpatch speaketh truth - there's already a declaration in
acpi/processor.h anyway.
I'll leave it alone though. Cleaning up acpi code isn't on the agenda
for today.
Please integrate checkpatch into your patch preparation tools. It
finds stuff.
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
