Re: [PATCH] fujitsu-laptop: support led-class as module

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi

> > Please consider slipping this in to 2.6.31-rc since it's a fairly trivial
> > bug fix to ensure that fujitsu-laptop uses the LEDS class even when the LEDS
> > class been compiled as a module.  If that's not possible or viewed as
> > inappropriate then let's go for 2.6.32.
> > :
>
> Don't you need to exclude
> 
> CONFIG_LEDS_CLASS=m
> CONFIG_FUJITSU_LAPTOP=y

Hmm, good point.  Admittedly this would be a rare case since most
distributors would ship with both CONFIG_LEDS_CLASS and
CONFIG_FUJITSU_LAPTOP set to "m" - a situation which the proposed patch
at least makes workable.

> I think the Kconfig-fu is "depends on LEDS_CLASS || LEDS_CLASS=n".

So, basically something like this should do the trick:

signed-off-by: Alan Jenkins <sourcejedi.lkml@xxxxxxxxxxxxxx>
signed-off-by: Joathan Woithe <jwoithe@xxxxxxxxxxxxxxxxxxxxxxx>

--- a/drivers/platform/x86/Kconfig	2009-08-26 11:03:20.000000000 +0930
+++ b/drivers/platform/x86/Kconfig	2009-08-26 11:04:28.000000000 +0930
@@ -82,6 +82,7 @@
 	depends on ACPI
 	depends on INPUT
 	depends on BACKLIGHT_CLASS_DEVICE
+	depends on LEDS_CLASS || LEDS_CLASS=n
 	---help---
 	  This is a driver for laptops built by Fujitsu:

Regards
  jonathan
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux