On 8/21/09, Mario Limonciello <mario_limonciello@xxxxxxxx> wrote: > Alan Jenkins wrote: >> On 8/19/09, Mario Limonciello <Mario_Limonciello@xxxxxxxx> wrote: >> >> Don't you still need to call platform_device_del() for the fail_rfkill >> case? >> >> > It was previously only called if the sysfs attribute creation failed. > So if it does need to be called, then there was a bug previously there too. Nope, look at it again. > @@ -481,11 +326,7 @@ static int __init compal_init(void) > return 0; > > fail_rfkill: > -fail_platform_device2: > - > - platform_device_del(compal_device); > - > -fail_platform_device1: > +fail_platform_device: > > platform_device_put(compal_device); Without this patch, fail_rfkill falls through to fail_platform_device2, and calls platform_device_del(). With the patch, the call to platform_device_del() is removed, so it will no longer be called for the fail_rfkill case. It's not a pre-existing bug. Regards Alan -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
