On 8/19/09, Mario Limonciello <mario_limonciello@xxxxxxxx> wrote: > Johannes: > > Johannes Berg wrote: >> On Wed, 2009-08-19 at 13:36 -0500, Mario Limonciello wrote: >> >> >> >> >> Isn't that missing sysfs_remove_group()? >> >> johannes >> > The third patch in the (updated) series is dropping the sysfs bits, so > sysfs_remove_group is removed there. That's not ideal. Each patch should stand on its own; it's bad form to introduce a bug in one patch and fix it in the next one. Even something obscure like omitting to free the sysfs group when setup_rfkill() fails. I would suggest merging these two patches into one. That would avoid adding sysfs_remove_group() in this patch, just to remove it in the next one. It also avoids the question in this patch, of what happens to the rfkill interface if you write to the sysfs file. Alan -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
