Hi, On 8/19/09, Alan Jenkins <sourcejedi.lkml@xxxxxxxxxxxxxx> wrote: > On 8/18/09, Alan Jenkins <sourcejedi.lkml@xxxxxxxxxxxxxx> wrote: >> On 8/2/09, Corentin Chary <corentin.chary@xxxxxxxxx> wrote: >>> Thanks, >>> Applied in acpi4asus eeepc tree: >>> http://git.iksaif.net/?p=acpi4asus.git;a=shortlog;h=refs/heads/eeepc-laptop >>> With two other patch on top of yours (wimax and __init). >>> I think I'll send them for 2.6.32 because there is a lot of change. >> >> That was the idea. Thanks! I am suspicious of your __init and >> ABI-doc commits, I will have a closer look at them :-). > > Ok, the ABI-doc looks good. There's just one typo: "Control he card > reader". > > However I do think it's suspicious to have an __init function, > eeepc_hotk_add(), as an "add" method on the ACPI device. This isn't > generally acceptable because hotplug can call the "add" method after > the driver is loaded. There is a special registration function for > *platform* devices, platform_driver_probe(), which allows init code to > be marked __init if hotplug can be ruled out. But there is no > equivalent for ACPI. > > If we add the __init annotations, we open a codepath which would lead > to a crash. We don't expect the firmware to ever trigger the crash, > but is it worth the risk just to save a few kilobytes? > > Alan > Hi, Thanks for the review. There is more documentation patchs in acpi4asus and asus-laptop branches as well, maybe you can review them too ? About the __init patch, I think I'll revert it if this can lead to a crash. -- Corentin Chary http://xf.iksaif.net - http://uffs.org -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
