On Friday 14 August 2009 01:53:40 pm Valdis.Kletnieks@xxxxxx wrote: > On Fri, 14 Aug 2009 10:44:50 MDT, Bjorn Helgaas said: > > > I don't quite understand how this oops happens, though. It seems that > > we crashed in this path: > > > > acpi_device_probe > > acpi_bus_driver_init > > driver->ops.add (calls acpi_video_bus_add) > > acpi_device_install_notify_handler > > hid = acpi_device_hid(device) > > strcmp(hid, ACPI_BUTTON_HID_POWERF)) > > *** OOPS, hid == NULL *** > > > > But the acpi_video_bus driver claims devices using ACPI_VIDEO_HID > > ("LNXVIDEO"), and acpi_device_set_id() already does synthesize > > that HID, so acpi_device_hid() should have been valid. So why > > did we oops? > > When I tripped over it, acpi_device_set_id() *wasn't* synthesizing an HID, > it was explicitly setting a NULL pointer. What I don't understand is why the acpi_video_bus driver could get bound to the device if the device didn't have a HID. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html