On Thu, 13 Aug 2009, Bjorn Helgaas wrote: > On Thursday 06 August 2009 05:18:12 pm Hugh Dickins wrote: > > It's up to Len to choose, but I thought we preferred... > > > > From: Hugh Dickins <hugh.dickins@xxxxxxxxxxxxx> > > > > acpi_device->pnp.hardware_id and unique_id are now allocated pointers, > > replacing the previous arrays. acpi_device_install_notify_handler() > > oopsed on the NULL hid when probing the video device, > > I'm sorry I wasn't aware of the acpi_device_install_notify_handler() > issue until just now, since I added the code that oopses (46ec8598fd). Sorry for not Cc'ing you: but you can hardly be blamed for not foreseeing future changes which might affect your code. > > I recently posted patches that removed the dependency on the HID > in this path: > > http://marc.info/?l=linux-acpi&m=124907623701270&w=2 > > I thought Len said they had been applied to acpi-test, but I don't > see them there. > > But I don't object to Hugh's patch, since it might be useful for other > paths. My original patch, when I hit the bug, was just to acpi_device_install_notify_handler(): I have never seen a problem anywhere else, and your patch would deal with that. But Lin Ming believes there might be issues elsewhere (I have no idea), posting a more general patch; then my patch here was a retort to that. What I'm saying is: so far as I know, your patch is more appropriate than mine; but probably Lin Ming knows better, and mine needed too. Hugh -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
