On Wed, 12 Aug 2009, Rafael J. Wysocki wrote: > > The one thing I'm not sure of is the pm_runtime_put_noidle calls in > > driver_probe_device and __device_release_driver. It seems that we > > should always call pm_runtime_put regardless of whether the probe > > succeeds or not. > > Did you mean pm_runtime_put_sync()? Yes. I haven't used the new code yet so the names don't stick in my mind. > > For example, the USB stack is set up to suspend devices that don't have > > a driver (this is handled at the bus subsystem level). But if probing > > failed, there wouldn't be any idle callback and so the suspend wouldn't > > take place. > > OK, I'll make this change. Thanks. Now I just have to figure out the best way to convert USB over to the new framework... Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
