On Friday 31 July 2009 01:26:20 pm Moore, Robert wrote: > We've been wrapping up ACPI 4.0 changes. I hope to take a look at this next week. Oh, right, I saw mail about that a day or two ago and figured you must be pretty busy :-) I do hope to use the postorder traversal, but there are still some significant Linux issues to work out first, so there's no big rush. Bjorn > >-----Original Message----- > >From: Bjorn Helgaas [mailto:bjorn.helgaas@xxxxxx] > >Sent: Friday, July 31, 2009 11:17 AM > >To: Moore, Robert > >Cc: Len Brown; linux-acpi@xxxxxxxxxxxxxxx > >Subject: Re: [PATCH 0/2] ACPICA: add postorder namespace walk > > > >On Friday 17 July 2009 11:27:16 am Bjorn Helgaas wrote: > >> AcpiWalkNamespace() only supports preorder traversal of the namespace. > >> This visits a node before any of its children, so it works well for > >> adding new devices. However, when removing devices, we need a postorder > >> traversal so we can remove children before the parents. > >> > >> These patches add a new AcpiWalkNamespace2() interface that takes two > >> callback arguments: one for preorder traversal and another for postorder. > >> These patches don't change the behavior of AcpiWalkNamespace(). > >> > >> Note that the existing preorder AcpiWalkNamespace() never actually visits > >> the starting node. Therefore, we skip it in postorder also. > > > >Hi Bob, > > > >Any feedback on these patches, or on the question of whether > >AcpiWalkNamespace() should visit the starting node? (I expect > >that the starting node question will be most easily resolved > >by a documentation update.) > > > >Bjorn > > > > -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html