On Thursday 25 June 2009, Rafael J. Wysocki wrote: > On Thursday 25 June 2009, Alan Stern wrote: > > On Wed, 24 Jun 2009, Alan Stern wrote: > > > More comments to follow when I get time to review more of the code... > > > > Here we go. This isn't so detailed, because I wasn't able to do a > > detailed review. Frankly, the code is kind of a mess. > > > > The whole business about the runtime_notify and RPM_NOTIFY flags is > > impenetrable. My suggestion: Rename runtime_notify to notify_pending > > and eliminate RPM_NOTIFY. Then make sure that notify_pending is set > > whenever a notify work item is queued. > > I was going to do exactly that, but I realized it wouldn't work in general, > because ->runtime_idle() could run __pm_runtime_suspend() in theory. > > The runtime_notify bit is only needed for pm_runtime_disable() so that it > knows there's a work item to cancel. > > > The pm_notify_or_cancel_work routine should just be pm_notify_work. > > It's silly to submit a workqueue item just to cancel a delayed > > workqueue item! > > Maybe, but how do you think we should cancel it? cancel_delayed_work() > doesn't guarantee that the work structure used for queuing the work will > not be accessed after it's returned and we can't schedule the next suspend > request until we know it's safe. So, we have to use cancel_delayed_work_sync() > for that, which can't be done from interrupt context, so we need to do it in a > work function. BTW, the problem is this. Say we queue an idle notification, so power.work is used for this purpose. Then, suspend is requested, but we cannot cancel the notification asynchronously, so we can only queue the suspend. power.suspend_work is used for that. Now, assume a resume is requested, so seemingly we need to queue a resume (the suspend request is pending and we have to cancel it with cancel_delayed_work_sync()), but power.work is already in use. There are two ways to handle this IMO: (1) use yet another 'struct work' variable (suboptimal) and (2) make the idle notification work function cancel the suspend instead of running the notification (that's what I did and I don't see how I can avoid it without doing (1)). Best, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
