Re: [PATCH 0/9 v2] ACPI: remove .start() and .stop() methods

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Mon, 22 Jun 2009, Bjorn Helgaas wrote:

> From: Bjorn Helgaas <bjorn.helgaas@xxxxxx>
> 
> These patches remove several .start() methods (by folding them into
> .add() methods) and a .stop() method (by folding it into .remove()).
> There are no remaining .stop() methods, so I also removed it from
> the driver_ops structure.
> 
> This simplifies the ACPI driver structure and will make it easier to
> support hotplug in the Linux/ACPI core.
> 
> They also remove the KOBJ_ONLINE and KOBJ_OFFLINE events generated
> by the processor driver for CPU hotplug events.  As far as I know,

> these events are unused.
> 
> I don't have a way to test most of these changes, unfortunately, so
> I'd welcome any feedback or testing reports.
> 
> These apply to the acpi-test branch.
> 
> ---
> 
> Bjorn Helgaas (9):
>       ACPI: processor: remove KOBJ_ONLINE/KOBJ_OFFLINE events
>       ACPI: processor: clean up in acpi_processor_start() error exits
>       ACPI: processor: move acpi_processor_start() after acpi_processor_add()
>       ACPI: processor: remove .start() method
>       ACPI: memory hotplug: remove .start() method
>       ACPI: EC: move acpi_ec_start() after acpi_ec_add()
>       ACPI: EC: remove .start() method
>       ACPI: EC: remove .stop() method
>       ACPI: remove unused acpi_device_ops .stop method
> 
> 
>  drivers/acpi/acpi_memhotplug.c |   40 +++----
>  drivers/acpi/ec.c              |  118 ++++++++--------------
>  drivers/acpi/processor_core.c  |  219 +++++++++++++++++-----------------------
>  drivers/acpi/scan.c            |    5 -
>  include/acpi/acpi_bus.h        |    2 
>  5 files changed, 153 insertions(+), 231 deletions(-)


WARNING: line over 80 characters
#229: FILE: drivers/acpi/processor_core.c:710:
+						  
pr->performance_platform_limit);

WARNING: line over 80 characters
#235: FILE: drivers/acpi/processor_core.c:716:
+						  dev_name(&device->dev), 
event, 0);

WARNING: line over 80 characters
#241: FILE: drivers/acpi/processor_core.c:722:
+						  dev_name(&device->dev), 
event, 0);

ERROR: that open brace { should be on the previous line
#266: FILE: drivers/acpi/processor_core.c:747:
+static struct notifier_block acpi_cpu_notifier =

applied to acpi-test

thanks,
Len Brown, Intel Open Source Technology Center


--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux