Matthew Garrett wrote: > On Fri, Jun 19, 2009 at 07:15:12AM -0400, Rafi Rubin wrote: >> Added a bit of missing code needed to handle switch events. >> >> Added the definitions for the hinge rotation as seen on the >> Latitude XT tablet. > > Having thought about this a bit more, I think there's a pretty > fundamental problem right now - we don't know whether we're in tablet > mode or not when we boot, so can't set the initial state. Software that > depends on that may be rather confused as a result... I agree polling the tablet state would be a good thing. But that does not mean we should not support the signals until we are ready to support polling. If you are suggesting that we should not use an EV_SW because we will eventually poll the hardware instead of keeping the state in software, then I have no problem with sending keys or other events. However if you still think keeping the state in software and using EV_SW is a good idea, this code is independent of the probe code. And I think the value of having this support is well worth the potential harm. After all, it thinks its in non-tablet mode until the signal comes in that its switching to tablet. How is this any worse than always thinking its in non-tablet mode? Rafi -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
