On Thu, 21 May 2009, yakui_zhao wrote: > + sprintf(acpi_device_bid(device), "CPU%X", pr->id); Is this safe against overflows, i.e. is pr->id something *we* set? Because if it is in any way read from the ACPI firmware, you have to either use snprintf, or use the format string to limit the %X to a safe lenght... -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
