Re: [PATCH 7/7] x86/pci: update pirq_enable_irq to setup io apic routing -v2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx> wrote:

> On Thu, 7 May 2009 16:12:22 +0200
> Ingo Molnar <mingo@xxxxxxx> wrote:
> 
> > 
> > * Yinghai Lu <yinghai@xxxxxxxxxx> wrote:
> > 
> > > 
> > > so we could set io apic routing only when enable device irq.
> > > 
> > > also could make setup_IO_APIC_irqs and setup_ioapic_dest only handle
> > > first ioapic...
> > > 
> > > v2: remove one one not needed style change.
> > >     merge the patch only setup io_apic for acpi on in
> > > setup_IO_APIC_irqs
> > > 
> > > [ Impact: make mptable irq enable more like acpi is used, and
> > > numa_irq_desc could get correct node when acpi=off ]
> > > 
> > > Signed-off-by: Yinghai Lu <yinghai@xxxxxxxxxx>
> > > 
> > > ---
> > >  arch/x86/kernel/apic/io_apic.c |  148
> > > ++++++++++++++++++++---------------------
> > > arch/x86/pci/irq.c             |   84 ++++++++--------------- 2
> > > files changed, 103 insertions(+), 129 deletions(-)
> > 
> > Jesse, did this patch have your Acked-by?
> 
> Yeah, both of them are fine with me.  Ultimately you get to keep 
> any broken pieces from io_apic changes anyway, right? :)

Yeah, generally. But the wider the blame can be spread when it does 
break, the better! ;-)

> Acked-by: Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx>

Thanks!

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux