Hi,
The ACPI battery driver does something strange with the generic power
supply class, when the battery is removed from my laptop. Instead of
clearing the "present" attribute of the class device, it removes the
entire class device.
Can this be corrected, or is there a specific reason for it?
Patch follows for illustration purposes.
If this can be changed, I'd also try to cleanup acpi_battery_update().
I don't think it's right that CONFIG_ACPI_SYSFS_POWER affects the
control flow. When it's disabled, acpi_battery_present() is not tested
before calling acpi_battery_get_state(). It might not cause any
problems, but it is evil.
diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c
index 69cbc57..050444a 100644
--- a/drivers/acpi/battery.c
+++ b/drivers/acpi/battery.c
@@ -482,6 +482,11 @@ static int sysfs_add_battery(struct acpi_battery *battery)
return device_create_file(battery->bat.dev, &alarm_attr);
}
+static void sysfs_update_battery(struct acpi_battery *battery)
+{
+ power_supply_changed(&battery->bat);
+}
+
static void sysfs_remove_battery(struct acpi_battery *battery)
{
if (!battery->bat.dev)
@@ -500,7 +505,7 @@ static int acpi_battery_update(struct acpi_battery *battery)
return result;
#ifdef CONFIG_ACPI_SYSFS_POWER
if (!acpi_battery_present(battery)) {
- sysfs_remove_battery(battery);
+ sysfs_update_battery(battery);
battery->update_time = 0;
return 0;
}
@@ -513,8 +518,7 @@ static int acpi_battery_update(struct acpi_battery *battery)
acpi_battery_init_alarm(battery);
}
#ifdef CONFIG_ACPI_SYSFS_POWER
- if (!battery->bat.dev)
- sysfs_add_battery(battery);
+ sysfs_update_battery(battery);
#endif
return acpi_battery_get_state(battery);
}
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
