On Thu, 23 Apr 2009, Len Brown wrote: > On Fri, 24 Apr 2009, yakui_zhao wrote: > > > On Fri, 2009-04-24 at 03:50 +0800, Len Brown wrote: > > > > Hi, Len > > The issue can be fixed by the patch from Matthew. > > In Matthew's patch the acpi video is also selected when the i915 is > > compiled as builtin-kernel module. > > But IMO this is not very good. From the Kconfig file we know that > > acpi video driver depends on the following configuration: > > BACKLIGHT_CLASS_DEVICE && VIDEO_OUTPUT_CONTROL > > > > If the VIDEO_OUTPUT_CONTROL/BACKLIGHT_CLASS_DEVICE is not selected, > > then it will still fail in kernel compilation. > > Matthew's patch is in. > Please send me an additional patch for the additionanl failure case. Yakui speaks the truth, all hail Yakui:-) "ACPI/i915: build fix" is dropped, because it fixes drivers/built-in.o: In function `intel_opregion_init': (.text+0x9d540): undefined reference to `acpi_video_register' but in defconfig, it causes: drivers/built-in.o: In function `acpi_video_bus_put_devices': video.c:(.text+0x411d2): undefined reference to `video_output_unregister' drivers/built-in.o: In function `acpi_video_bus_add': video.c:(.text+0x42c4e): undefined reference to `video_output_register' -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html