From: Zhao Yakui <yakui.zhao@xxxxxxxxx> When the boot option of "processor.max_cstate=0" is added, the C-state won't be configured correctly. In such case the cpu idle function will access the uninitialized memory region and then kernel panic will happen. So it is necessary to add the module param check for the processor.max_cstate. If it is equal to or less than zero, it will be ignored. If it is beyond the max threshold, it is also ignored. http://bugzilla.kernel.org/show_bug.cgi?id=13142 Signed-off-by: Zhao Yakui <yakui.zhao@xxxxxxxxx> --- drivers/acpi/processor_idle.c | 27 ++++++++++++++++++++++++++- 1 file changed, 26 insertions(+), 1 deletion(-) Index: linux-2.6/drivers/acpi/processor_idle.c =================================================================== --- linux-2.6.orig/drivers/acpi/processor_idle.c 2009-04-21 15:48:52.000000000 +0800 +++ linux-2.6/drivers/acpi/processor_idle.c 2009-04-24 10:00:47.000000000 +0800 @@ -70,7 +70,32 @@ #define PM_TIMER_TICKS_TO_US(p) (((p) * 1000)/(PM_TIMER_FREQUENCY/1000)) static unsigned int max_cstate __read_mostly = ACPI_PROCESSOR_MAX_POWER; -module_param(max_cstate, uint, 0000); + +static int param_set_max_cstate(const char *val, struct kernel_param *kp) +{ + unsigned long cstate = 0; + int ret = 0; + + if (!val) + return -EINVAL; + + ret = strict_strtoul(val, 10, &cstate); + if (ret == -EINVAL || (unsigned int)cstate != cstate) + return -EINVAL; + /* + * if the value is equal to or less than zero, it will be ingored. + * Of course it will also be ignored if it is bigger than the + * threshold of ACPI_PROCESSOR_MAX_POWER. + */ + if (cstate <= 0 || cstate > ACPI_PROCESSOR_MAX_POWER) + return -EINVAL; + + max_cstate = cstate; + + return 0; +} +module_param_call(max_cstate, param_set_max_cstate, NULL, + &max_cstate, 0000); static unsigned int nocst __read_mostly; module_param(nocst, uint, 0000); -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
