Moore, Robert wrote:
Please explain further what this accomplishes. This removes the use of any cache for the acpi operand object? What about performance? That was the major reason the cache was added in the first place.
Our cache implementation fights with memory debugger in Microsoft Visual C standard library. If you care about performance, the best way is to disable this memory debugger, as we don't use it anyway. You could accomplish it in two ways, one is to disable all DEBUG, the other is to only disable memory debugger.
With this patch, every object type is allowed to have it's own size, thus allowing separate optimization. For example, "extra" object, tied to region and field objects could be folded in to save both space and code, this optimization was implemented by Kuzmich some time ago, but was lost during layoffs.
Regards,
Alex.
-----Original Message-----
From: Alexey Starikovskiy [mailto:astarikovskiy@xxxxxxx]
Sent: Friday, April 17, 2009 11:26 AM
To: Moore, Robert; Len Brown
Cc: ACPI Devel Maling List
Subject: [RFC][PATCH] ACPICA: Drop Operand cache
Hi,
I've played with AcpiOperandObject union and corresponding cache. Removing
the union does not seem to be viable -- patch easily overcomes .5 meg
barrier, without any visible change. Dropping only the cache and making all
individual objects allocated from heap requires smaller number of changes
and chould make SLAB/SLUB developers happy.
Regards,
Alex.
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
