Re: [patch 1/8] x86: oqo: depends on INPUT_POLLDEV

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wednesday 04 March 2009 11:55:24 akpm@xxxxxxxxxxxxxxxxxxxx wrote:
> From: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
>
> oqo driver uses polled input functions, so make it depend
> on INPUT_POLLDEV.
>
> ERROR: "input_register_polled_device" [drivers/platform/x86/oqo-wmi.ko]
> undefined! ERROR: "input_allocate_polled_device"
> [drivers/platform/x86/oqo-wmi.ko] undefined! ERROR:
> "input_free_polled_device" [drivers/platform/x86/oqo-wmi.ko] undefined!
> ERROR: "input_unregister_polled_device" [drivers/platform/x86/oqo-wmi.ko]
> undefined!
>
> Signed-off-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
> Cc: Matthew Garrett <mjg59@xxxxxxxxxxxxx>
> Cc: Ingo Molnar <mingo@xxxxxxx>
> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Cc: "H. Peter Anvin" <hpa@xxxxxxxxx>
> Cc: Len Brown <lenb@xxxxxxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> ---
>
>  drivers/platform/x86/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -puN drivers/platform/x86/Kconfig~x86-oqo-depends-on-input_polldev
> drivers/platform/x86/Kconfig ---
> a/drivers/platform/x86/Kconfig~x86-oqo-depends-on-input_polldev +++
> a/drivers/platform/x86/Kconfig
> @@ -137,7 +137,7 @@ config MSI_LAPTOP
>  config OQO_WMI
>         tristate "OQO WMI extras"
>         depends on ACPI_WMI
> -       depends on INPUT
> +       depends on INPUT && INPUT_POLLDEV

Make it "select INPUT_POLLDEV". Input-polldev is just a library code, users
should not have to select it for some drivers to become available.

-- 
Dmitry

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux