Re: [patch 4/4] dell-wmi: support additional keys

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Apr 10, 2009 at 11:16:32PM -0700, akpm@xxxxxxxxxxxxxxxxxxxx wrote:
> From: Rafi Rubin <rafi@xxxxxxxxxxxxxx>
> 
> Added key codes generated by screen rotation on the Latitude XT.  0xe046
> is sent when changing to tablet mode, and 0xe047 when it returns to
> desktop mode.
> 
> Signed-off-by: Rafi Rubin <rafi@xxxxxxxxxxxxxx>
> Cc: Matthew Garrett <mjg@xxxxxxxxxx>
> Cc: Len Brown <len.brown@xxxxxxxxx>
> Cc: Eric Piel <E.A.B.Piel@xxxxxxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>

I don't like this - it should really be using the switch event, not 
sending random programmable buttons.

-- 
Matthew Garrett | mjg59@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux