Re: [PATCH 21/98] ACPICA: Check for non-zero address before being converted to GAS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2009-04-02 at 19:59 +0800, Thomas Renninger wrote:
> On Saturday 28 March 2009 05:30:56 Len Brown wrote:
> > From: Lin Ming <ming.m.lin@xxxxxxxxx>
> > 
> > Reported-by: FreeBSD community
> > Signed-off-by: Lin Ming <ming.m.lin@xxxxxxxxx>
> > Signed-off-by: Len Brown <len.brown@xxxxxxxxx>
> Does this fix something for real?

It's a regression fix.
see "linux-next acpi changes make vmware server unusable"
http://marc.info/?l=linux-acpi&m=123620365021296&w=2

Lin Ming

> If yes, please add:
> CC: stable@xxxxxxxxxx
> not sure if not.
> > ---
> >  drivers/acpi/acpica/tbfadt.c |   16 +++++++++-------
> >  1 files changed, 9 insertions(+), 7 deletions(-)
> > 
> > diff --git a/drivers/acpi/acpica/tbfadt.c 
> b/drivers/acpi/acpica/tbfadt.c
> > index a8191ef..43fe886 100644
> > --- a/drivers/acpi/acpica/tbfadt.c
> > +++ b/drivers/acpi/acpica/tbfadt.c
> > @@ -618,12 +618,14 @@ static void acpi_tb_setup_fadt_registers(void)
> >  		    ACPI_ADD_PTR(struct acpi_generic_address, &acpi_gbl_FADT,
> >  				 fadt_pm_info_table[i].source);
> >  
> > -		acpi_tb_init_generic_address(fadt_pm_info_table[i].target,
> > -					     source64->space_id,
> > -					     pm1_register_byte_width,
> > -					     source64->address +
> > -					     (fadt_pm_info_table[i].
> > -					      register_num *
> > -					      pm1_register_byte_width));
> > +		if (source64->address) {
> > +			acpi_tb_init_generic_address(fadt_pm_info_table[i].
> > +						     target, source64->space_id,
> > +						     pm1_register_byte_width,
> > +						     source64->address +
> > +						     (fadt_pm_info_table[i].
> > +						      register_num *
> > +						      pm1_register_byte_width));
> > +		}
> >  	}
> >  }
> > -- 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux