Re: [patch] x86, acpi: add support for x2apic ACPI extensions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



scripts/checkpatch.pl

ERROR: "foo * bar" should be "foo *bar"
#34: FILE: arch/x86/kernel/acpi/boot.c:233:
+acpi_parse_x2apic(struct acpi_subtable_header * header, const unsigned 
long end)

WARNING: line over 80 characters
#70: FILE: arch/x86/kernel/acpi/boot.c:321:
+acpi_parse_x2apic_nmi(struct acpi_subtable_header * header, const 
unsigned long end)

ERROR: "foo * bar" should be "foo *bar"
#70: FILE: arch/x86/kernel/acpi/boot.c:321:
+acpi_parse_x2apic_nmi(struct acpi_subtable_header * header, const 
unsigned long end)

WARNING: line over 80 characters
#109: FILE: arch/x86/kernel/acpi/boot.c:883:
+	    acpi_table_parse_madt(ACPI_MADT_TYPE_LOCAL_X2APIC_NMI, 
acpi_parse_x2apic_nmi, 0);

WARNING: line over 80 characters
#169: FILE: drivers/acpi/numa.c:140:
+					  "SRAT Processor 
(x2apicid[0x%08x]) in proximity domain %d %s\n",

ERROR: spaces required around that '?' (ctx:VxE)
#172: FILE: drivers/acpi/numa.c:143:
+					  (p->flags & 
ACPI_SRAT_CPU_ENABLED)?
 					                                    
^

ERROR: "foo * bar" should be "foo *bar"
#194: FILE: drivers/acpi/numa.c:207:
+acpi_parse_x2apic_affinity(struct acpi_subtable_header * header,

WARNING: usage of NR_CPUS is often wrong - consider using cpu_possible(), 
num_possible_cpus(), for_each_possible_cpu(), etc
#220: FILE: drivers/acpi/numa.c:287:
+				      NR_CPUS);

WARNING: space prohibited between function name and open parenthesis '('
#232: FILE: include/linux/acpi.h:100:
+void acpi_numa_x2apic_affinity_init (struct acpi_srat_x2apic_cpu_affinity 
*pa);

WARNING: line over 80 characters
#295: FILE: drivers/acpi/tables.c:72:
+			       (p->lapic_flags & ACPI_MADT_ENABLED) ? 
"enabled" : "disabled");

WARNING: line over 80 characters
#313: FILE: drivers/acpi/tables.c:137:
+			       mps_inti_flags_polarity[p->inti_flags & 
ACPI_MADT_POLARITY_MASK	],

ERROR: space prohibited before that close square bracket ']'
#313: FILE: drivers/acpi/tables.c:137:
+			       mps_inti_flags_polarity[p->inti_flags & 
ACPI_MADT_POLARITY_MASK	],

WARNING: line over 80 characters
#314: FILE: drivers/acpi/tables.c:138:
+			       mps_inti_flags_trigger[(p->inti_flags & 
ACPI_MADT_TRIGGER_MASK) >> 2],

total: 5 errors, 8 warnings, 259 lines checked


--
Len Brown, Intel Open Source Technology Center

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux