On Tuesday 24 March 2009 01:05:43 am Jeremy Fitzhardinge wrote: > Tian, Kevin wrote: > > OK, then it's safe to avoid that change. I had thought that dom0's 0-1M > > is identity-mapped to machine 0-1M... :-) > > No, only the ISA 640k-1M region. I'm speaking out of turn here because I don't work on Xen or suspend/resume. However, I do try to clean up random bits of ACPI, and I have to say this patch looks like a pain in the maintenance department. Having tests for a specific hypervisor is unpleasant. We don't want to end up with tests for a collection of hypervisors. It looks like suspend becomes a weird hybrid of ACPI and Xen, which makes it harder to reason about future suspend changes. And all this discussion about 640k-1M and dom0 identity mapping and "there's no special effort to remap it" and whether there are conflicts makes me nervous. There's no way all those assumptions can be remembered or verified five years down the road. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html