On Fri, Mar 20, 2009 at 02:00:04PM +0000, Matthew Garrett wrote: > On Fri, Mar 20, 2009 at 05:52:14PM +0900, Mattia Dongili wrote: > > > I'm more of the idea to provide a module option to force the setup > > callback if the module is not in the DMI list. > > Although for now all of the models that have SN07 and friends seem to > > benefit from throwing some magic numbers at them. > > I suspect that this is how new machines expect to be controlled. agreed, but I need to figure out if the initialization sequence is really the same for those new TT/Z models and the olders one (see also below). > > > calling the ECON method on the SNC since some codepaths in the tables > > > seem to depend on them - but I'm also worried to a certain extent on how > > > much that might change driver interactions with some machines. > > > > My understanding about ECON is that it is always enabled if the embedded > > controller is enabled. The SPIC device has the same kind of dependency > > and as far as I could see ECON is always 1. So I don't think it makes > > much of a difference. > > I had one machine where ECON seemed to need to be called explicitly, but > I can't remember the details now. Calling it probably wouldn't hurt > anything. seems to be a TT and Z specific thing though. The DSDT on other models doesn't provide the ECON method. ... > > > + acpi_callsetfunc(sony_nc_acpi_handle, "SN07", 0x101, &result); > > > + > > > + acpi_callsetfunc(sony_nc_acpi_handle, "SN07", 0xb03, &result); > > > > hummm, this is very similar to the callback setup executed when matching > > the snc dmi list. > > On which vaio model did you get this numbers? Did you find the other > > initialization path (the one dependent on the DMI list) any useful on > > that model? i.e.: do you need both? > > The numbers correspond to enabling all events. I couldn't think of any > reason why we'd only want to enable a subset. The current nc setup code > seems to enable some events and then disable them again, which I don't > really understand. Well, the current sequence was taken from a trace in windows on a Vaio C Type, then it demonstrated to be helpful on other models as well. The SN07[1] method is very different from the Z and TT type to the AR, C, FE, FZ and N so I'm starting to suspect that we're just seeing a new generation of SNC based models. I'll see if some users with older models can give the new sequence a go. In the meantime can we make your sony_nc_function_setup less invasive and depend on the DMI to match? [1]: more dsdt tables here http://www.kamineko.org/dsdt-vaio/ -- mattia :wq! -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
