On Tuesday 10 March 2009 09:03:23 Zhang Rui wrote:
> Hi, all,
>
> here is the patch set I made recently, including some cleanups and fixes
> for the Thinkpad/Asus laptops with buggy _BQC/_BCL/_BCM implementation.
Nice!
Beside the one point that BIOSes without _BQC might end up with a
random brightness at start-up (I think it's that) and Matthew's comments,
I couldn't find anything bad.
Theoretically on BIOSes without _BQC we need to evaluate current AC/battery
state at start-up and take/set the corresponding brightness level.
This should be the only downside people see on such BIOSes, it was always
initialized to max state booted on battery or AC.
Thomas
> The first two patches checks if ACPI video driver fails to set/get the
> current brightness level, which is not done before.
>
> patch 3/4/5 are used to fix three different problems.
>
> 1. the brightness levels when machine is on AC/Battery are not exported
> by _BCL.
> 2. The supported brightness levels are reversed in the _BCL method.
> 3. Index values are used in _BQC/_BCL/_BCM method.
>
> The patches have not been tested yet.
> I send them here to see if someone has better ideas about these issues.
> Any comments are welcome. :)
>
> thanks,
> rui
>
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
