On Tue, Mar 10, 2009 at 04:03:29PM +0800, Zhang Rui wrote:
> + if (level_ac_battery > 2) {
> + ACPI_ERROR((AE_INFO, "Two many duplicates in _BCL package\n"));
> + goto out_free_levels;
Exiting here seems a little excessive? I'd just go with a warning and
carry on. In future maybe we could strip duplicates. Also, s/two/too/.
> /* don't sort the first two brightness levels */
> sort(&br->levels[2], count - 2, sizeof(br->levels[2]),
> acpi_video_cmp_level, NULL);
I think the comment here needs to be clarified - it sounds like you'll
ignore the first two in the package, even if they're actual values
rather than the ac and battery ones.
Otherwise:
Acked-by: Matthew Garrett <mjg@xxxxxxxxxx>
--
Matthew Garrett | mjg59@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
