On Fri, 2009-03-06 at 09:08 +0000, Richard Hughes wrote: > On Fri, 2009-03-06 at 00:52 +0000, Matthew Garrett wrote: > > Calling the ENAB method on Toshiba laptops results in notifications > > being sent when laptop hotkeys are pressed. This patch simply calls that > > method and sets up an input device if it's successful. > Great news - no polling! No polling is definitely a good thing. > Definitely +1 from me. I'll be a touch less gung-ho than Richard though. Have you looked at whether or not this method functions on more than the one laptop? Toshiba are notoriously good at getting their own interfaces wrong from one laptop to another. In addition, the fn+whatever keymaps are often different between laptops, especially for things like the WWW or MAIL buttons. Presumably if the hotkeys fail to activate then the normal /proc/acpi/toshiba/keys thing will continue? How will it interact with software stacks like HAL when the lock button is pressed? The patch itself looks clean and nice, I'm just concerned about its behaviour from laptop-to-laptop. Particularly the key-map thing. D. -- Daniel Silverstone http://www.simtec.co.uk/ PGP mail accepted and encouraged. Key Id: 2BC8 4016 2068 7895 -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
