Re: [PATCH 1/3] ACPI: pci: make new pci.h header local to driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday 24 February 2009 12:06:07 pm Bjorn Helgaas wrote:
> On Saturday 21 February 2009 09:28:31 pm Len Brown wrote:
> > I like this patch, but not wild about the name "pci.h"
> > 
> > there are already about 20 pci.h files in the tree.
> > sure, they are context specific, but still i don't like it.
> > 
> > (and I don't like having 11 acpi.h files in the tree either...)
> > 
> > how about acpi_pci.h?
> > 
> > yeah, i know it would be redundant, as it lives in drivers/acpi/ 
> > but as basically everything it the file starts with "acpi_pci..."
> > maybe a little redundancy can be seen as consistent?
> 
> Personally, I *like* the fact that we have a hierarchy where the
> context provides useful information.

P.S.  My opinion here might be influenced by the fact that I always use
"cscope -p4".  Cscope users who use the default (show only one path
component) would benefit a lot more from having redundant information
in the filename.

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux