On Tue, Feb 3, 2009 at 2:08 PM, Thomas Renninger <trenn@xxxxxxx> wrote: > On Monday 02 February 2009 21:22:46 Luca Tettamanti wrote: >> Il Mon, Feb 02, 2009 at 06:22:10PM +0100, Thomas Renninger ha scritto: >> > These two patches are tested on a ASUS machine and worked as expected, >> > but probably may still need some cleanup. >> >> I'd keep the DMI+HID approach since it's more flexible: >> - (AFAICS) Thinkpads have different methods for hwmon depending on the >> model and no fixed HID >> - With DMI it would be possible to include ASUS motherboards (ATK w/ >> hwmon) but exclude ASUS laptops (ATK w/o hwmon). > I thought the ATK01[01]0 devices are ASUS specific. Me too, I was thinking about using DMI_CHASSIS_TYPE to restrict the match only to motherboard (not notebooks). > I now found an ATK0100 (not the ATK0110 this is about) on a Sony and a > Samsung. > I still wonder why you want to restrict the check to ASUS. > Your ATK0110 driver would also load on any other machine which has such > a device. And why shouldn't a Samsung/Sony/... machine with a ATK0110 > device not access the hwmon sensor through it? Ah, I was unaware that it was used also by other vendors. It the same interface though? Do you have a dump of the DSDT of such machines? > Should we already look a bit deeper into the ATK0110 device in the quirk > to make sure it provides thermal, fan or other hwmon device accessing > functionality? Hum, maybe it's the best thing to do. Hans, Jean what do you think? Luca -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
