bd->props.brightness is a cached value. the current code has some potential problems when poking the backlight I/F. For example, 1. set the brightness level to 5 via sysfs I/F 2. set the backlight to another level via the procfs, 3. setting it back to 5 doesn't work because bd->props.brightness is still 5. http://bugzilla.kernel.org/show_bug.cgi?id=12249 Signed-off-by: Zhang Rui <rui.zhang@xxxxxxxxx> --- drivers/video/backlight/backlight.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) Index: linux-2.6/drivers/video/backlight/backlight.c =================================================================== --- linux-2.6.orig/drivers/video/backlight/backlight.c +++ linux-2.6/drivers/video/backlight/backlight.c @@ -134,10 +134,8 @@ static ssize_t backlight_store_brightnes else { pr_debug("backlight: set brightness to %d\n", brightness); - if (bd->props.brightness != brightness) { - bd->props.brightness = brightness; - backlight_update_status(bd); - } + bd->props.brightness = brightness; + backlight_update_status(bd); rc = count; } } -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
